Disable test builds on Windows and use macOS 11 in CI #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
changed the title
-DBUILD_TESTING=OFF on Windows for now-DBUILD_TESTING=OFF on Windows for now and use macOS 11 in CI
|
Since macOS 10.15 images are deprecated, I've bumped that workflow to macOS 11. |
fwcd
changed the title
-DBUILD_TESTING=OFF on Windows for now and use macOS 11 in CI
fwcd
changed the title
|
Huh, why don't we run tests on Windows...? We should have an issue open for that, but I don't see one. We could probably bump the Windows runner up to 2022 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't run the tests there anyway currently, so hopefully this should fix Windows CI (for now). This is effectively the same fix as microsoft/vcpkg#30454.